report: expand on "learn more" links #14091
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Up to document-title in the tree.
alexnj
changed the title
adamraine
reviewed
Jul 12, 2022
Contributor
adamraine
left a comment
adamraine
left a comment
There was a problem hiding this comment.
Quick comment dump for Accessibility. These are really just nit suggestions for consistency and specificity. Feel free to ignore them if you think the current stuff works better.
adamraine
reviewed
Jul 14, 2022
Contributor
adamraine
left a comment
adamraine
left a comment
There was a problem hiding this comment.
Comments for Byte Efficiency (mostly)
lighthouse-core/audits/byte-efficiency/efficient-animated-content.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Adam Raine <[email protected]>
paulirish
reviewed
Jul 18, 2022
Member
paulirish
left a comment
paulirish
left a comment
There was a problem hiding this comment.
as Adam did a11y and BE audits. I continued in the github order and completed through the dobetterweb audits, ending with uses-passive-event-listeners.js`
lighthouse-core/audits/dobetterweb/password-inputs-can-be-pasted-into.js
Outdated
Show resolved
Hide resolved
lighthouse-core/audits/dobetterweb/uses-passive-event-listeners.js
Outdated
Show resolved
Hide resolved
paulirish
approved these changes
Jul 18, 2022
Member
paulirish
left a comment
paulirish
left a comment
There was a problem hiding this comment.
aiight i went through the rest. I didnt doublecheck what adam did.
some small fixes here and there.
lgtm % the suggestions.
Co-authored-by: Paul Irish <[email protected]>
Co-authored-by: Adam Raine <[email protected]> Co-authored-by: Paul Irish <[email protected]>
connorjclark
changed the title
Co-authored-by: Connor Clark <[email protected]>
connorjclark
approved these changes
Jul 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12241.
I've taken a stab at expanding "Learn more" links in LH reports to be more descriptive and accessible. Most of the expansions fall into one of the two formats:
Feel free to suggest better expansions and I'll make the edits.