Skip to content

i18n: memoize getIcuMessageFn #14026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
paulirish wants to merge 1 commit into from
Closed

i18n: memoize getIcuMessageFn #14026

paulirish wants to merge 1 commit into from

Conversation

@paulirish
Copy link
Member

@paulirish paulirish commented May 19, 2022

i was running some -A runs and it felt quite slow. Turns out the createConfig times are ~500ms and most of that is in the getIcuMessageFn stuff.

I tried memoizing and the results are pretty excellent

node ./lighthouse-cli --quiet -A=./lighthouse-core/test/results/artifacts --config-path=./lighthouse-core/test/results/sample-config.js --output=json --output-path=./lighthouse-core/test/results/sample_v2.json; 
node -e "t = require('./lighthouse-core/test/results/sample_v2.json'); console.log(t.timing.entries.filter(e => e.name === 'lh:config').at(-1).duration)"
# this branch
436.51
160.34
157.83
161
156.81

# master
848.99
534.13
532.56
545.76
526.82

@paulirish paulirish requested a review from a team as a code owner May 19, 2022 00:32
@paulirish paulirish requested review from adamraine and removed request for a team May 19, 2022 00:32
connorjclark
connorjclark reviewed May 19, 2022
View reviewed changes
lighthouse-core/lib/i18n/i18n.js
};

return getIcuMessageFn;
return memoize(getIcuMessageFn);
Copy link
Collaborator

@connorjclark connorjclark May 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we lose types with this?

Copy link
Collaborator

@connorjclark connorjclark May 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://stackoverflow.com/questions/43382569/generic-memoize-function-returning-the-same-function-type

@brendankenny
Copy link
Contributor

brendankenny commented May 19, 2022

what ends up slowing it down? is it the formatters?

@brendankenny
Copy link
Contributor

brendankenny commented May 19, 2022

what ends up slowing it down? is it the formatters?

no, it's intl-messageformat parsing

@brendankenny brendankenny mentioned this pull request May 19, 2022
Merged
@paulirish
Copy link
Member Author

paulirish commented May 26, 2022

superceded by #14030

@paulirish paulirish closed this May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@connorjclark connorjclark connorjclark left review comments

@adamraine adamraine Awaiting requested review from adamraine adamraine was automatically assigned from GoogleChrome/lighthouse-hackers

Assignees

@adamraine adamraine

Labels

waiting4reviewer

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@paulirish @brendankenny @connorjclark @adamraine @devtools-bot