Skip to content

Conversation

@connorjclark
Copy link
Collaborator

ref #12689

@connorjclark connorjclark requested a review from a team as a code owner May 5, 2022 18:44
@connorjclark connorjclark requested review from adamraine and removed request for a team May 5, 2022 18:44
"**/*.js",
"../types/global-lh.d.ts",
],
}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brendankenny any notes?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's it for? I'm surprised anything changed

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we import treemap ui strings and the locales module in build-treemap.js

and that requires various types to exist on the global scope otherwise tsc fails

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW {"path": "./treemap/"}, in the root tsconfig.json would have also fixed it, though it's not necessarily bad to have a tsconfig for this folder too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants