core(user-flow): start/end navigation functions #13966
Conversation
adamraine
changed the title
adamraine
force-pushed
the
start-end-navigation
branch
from
eb020e8 to
f81be39
Compare
adamraine
changed the title
adamraine
changed the title
lighthouse-core/test/fraggle-rock/scenarios/start-end-navigation-test-pptr.js
Show resolved
Hide resolved
|
Yeah docs sound good. @paulirish is #14021 ready to go first? Also, just had an idea. We could add a new smoke test runner for this. I'll do it in a separate PR. |
| */ | ||
| async startNavigation(stepOptions) { | ||
| /** @type {ExternalPromise<() => void>} */ | ||
| const setupPromise = new ExternalPromise(); |
There was a problem hiding this comment.
why can't this just be a promise? looking at the extpromise impl i'm not seeing what's special about it…
There was a problem hiding this comment.
There's a pattern that the playwright guys used to do (and still do).. and i think it'd achieve what you're going for here…
let fulfill = () => {};
let reject = () => {};
const result = new Promise((res, rej) => { fulfill = res; reject = rej; });
// …
fulfill(continueNav)There was a problem hiding this comment.
That's not any different. It's just encapsulated. I like it.
There was a problem hiding this comment.
There's a big amount of indirection here that takes a moment to figure out. I tried to help in my comment suggestion.
There was a problem hiding this comment.
The main goal was to make the code easier to read by reducing the nested promises and such. It was a generic pattern that we might user later, but that's just wishful thinking I guess.
I'm fine going with paul's suggestion here.
4 participants
We previously discussed this idea 🔒 here. Using some promise/callback BS we can implement both the callback approach and start/end approach for user triggered navigations.