tests(smoke): run bundle smokes in a worker #13947
Conversation
| return { | ||
| lhr: result.lhr, | ||
| artifacts: result.artifacts, | ||
| log, |
There was a problem hiding this comment.
also we get logs now
| if (typeof globalThis === 'undefined') { | ||
| // @ts-expect-error - exposing for loading of dt-bundle. | ||
| global.globalThis = global; | ||
| if (!isMainThread && parentPort) { |
There was a problem hiding this comment.
I'm kinda on the fence about having this in a single file. It's nice to have a single file for all of our bundled smoke stuff, but it also means you have to read the same file in two different contexts. Is having the worker stuff in the same file necessary for this to work?
At the very least, can we highlight the "worker" section and the "main thread" section with comments?
There was a problem hiding this comment.
FWIW, since the worker only does one thing and then dies, it doesn't actually need to receive messages. The worker can just load from workerData and get rid of some of this complexity.
adamraine
left a comment
adamraine
left a comment
There was a problem hiding this comment.
Looks like you can merge from master to solve CI, LGTM
| global.globalThis = global; | ||
| // This runs only in the worker. The rest runs on the main thread. | ||
| if (!isMainThread && parentPort) { | ||
| (async () => { |
There was a problem hiding this comment.
technically don't we have top-level await? We might not want to break that seal yet, though
brendankenny
left a comment
brendankenny
left a comment
There was a problem hiding this comment.
Last comments are just style variations on what you already have, so take anything or leave it. Change looks great!
4 participants
This allows us to run these tests in parallel now.
ref #13943 (comment)