tests(crq): call setExtrasFn before using the urls #13910
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The helper function
createChainsFromMockRecordstakes a functionsetExtrasFnwhich modifies the network records made by default. Many tests will modify the urls, but the helper function uses the default url values when building the graph initiators (this is the old code):This didn't seem to prevent any tests from working, but it was unexpected (I was debugging something by looking at the generated devtools log and found the mismatch of urls here odd).
One test did break from this, and I really don't understand it... so I opted to resolve the breakage by introducing a boolean parameter to this function to recreate the previous bad behavior.