tests(lantern): correctly clear old trace data #13809
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
commented
Apr 1, 2022
|
|
||
| unzip -q golden-lantern-traces.zip | ||
| rm golden-lantern-traces.zip | ||
| echo $VERSION > version |
Collaborator
Author
There was a problem hiding this comment.
minor thing, this is better in case the unzipping failing halfway bc user accidentally cancels.
Collaborator
Author
|
|
adamraine
approved these changes
Apr 1, 2022
Contributor
I think it's cuz the tests haven't all finished yet (citation needed). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there are two versions of lantern data. the first one didn't have a "version" file, the second (And any future ones) do. the logic for deleting the old data didn't take into account that the version file would be missing
oops :)