core: use mainDocumentUrl instead of finalUrl
#13793
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (!url || url === pageUrl) { | ||
| if (!url || stylesheet.header.isInline) { | ||
| const contentPreview = UnusedCSS.determineContentPreview(stylesheet.content); | ||
| url = contentPreview; |
Collaborator
There was a problem hiding this comment.
(unrelated to pr) ugh we shouldn't be putting non-url strings in url fields. third party filter wont like this
lighthouse-core/audits/byte-efficiency/unminified-javascript.js
Outdated
Show resolved
Hide resolved
lighthouse-core/audits/byte-efficiency/unminified-javascript.js
Outdated
Show resolved
Hide resolved
This reverts commit 2643c51.
connorjclark
approved these changes
Apr 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 2 of #13706
There are still many usages of
finalUrlin a few situations:finalUrlis being used to get the origin of the pagefinalUrlis being used as the base for another URLfinalUrlis being used as the displayed URL but not used for any calculations