Skip to content

core(preload-lcp-image): be specific about when to do this #13771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
connorjclark merged 3 commits into from
Mar 31, 2022
Merged

core(preload-lcp-image): be specific about when to do this #13771

connorjclark merged 3 commits into from
Mar 31, 2022

Conversation

@connorjclark
Copy link
Collaborator

@connorjclark connorjclark commented Mar 22, 2022 •
edited
Loading

Goal is to help reduce confusion wrt future audit prioritize-lcp-image #13738

even in isolation, this change is good because the audit explicitly ignores images that are already in the initial HTML

@connorjclark connorjclark requested a review from a team as a code owner March 22, 2022 20:56
@connorjclark connorjclark requested review from adamraine and removed request for a team March 22, 2022 20:56
@connorjclark connorjclark changed the title core(preload-lcp-image): be specific about when to do this in desc core(preload-lcp-image): be specific about when to do this Mar 31, 2022
@connorjclark connorjclark merged commit d6dc026 into master Mar 31, 2022
@connorjclark connorjclark deleted the lcp-desc branch March 31, 2022 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@adamraine adamraine adamraine approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@adamraine adamraine

Labels

waiting4reviewer

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@connorjclark @adamraine @devtools-bot