core(user-flow): audit flow from artifacts json #13715
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
approved these changes
Mar 3, 2022
Collaborator
connorjclark
left a comment
connorjclark
left a comment
There was a problem hiding this comment.
I expected this to work with -GA, but I guess that will come later? If so, please rename the PR title to reflect that this isn't actually loading or saving artifacts to disk during normal operation.
connorjclark
reviewed
Mar 3, 2022
connorjclark
reviewed
Mar 3, 2022
adamraine
changed the title
connorjclark
reviewed
Mar 3, 2022
| const configJson = gatherStep.config || flowConfig; | ||
| const {gatherMode} = artifacts.GatherContext; | ||
| const {config} = initializeConfig(configJson, {...configContext, gatherMode}); | ||
| runnerOptions = { |
Collaborator
There was a problem hiding this comment.
seems we could add a second property like _gatherStepRunnerOptions or something, and keep runner options data there. could be an array or a weakmap (if array, this loop changes to for (let i ..., if weakmap can keep for loop as is). I think conceptually the weakmap makes sense here.
Contributor
Author
There was a problem hiding this comment.
I decided to go with the weak map approach here. Keeps GatherStep type clear of any extra stuff
adamraine
changed the title
This was referenced Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps 4 & 5 of #13364. I combined them because I needed step 5 to test step 4 🤷
Lol +900,000 from the artifacts file. It contains the DT logs and traces inline for the equivalent of 3 normal LH runs.
Ref
#11313