Skip to content

tests: add snapshot tests for cli-flags.js #13596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
connorjclark merged 4 commits into from
Jan 26, 2022
Merged

tests: add snapshot tests for cli-flags.js #13596

connorjclark merged 4 commits into from
Jan 26, 2022

Conversation

@connorjclark
Copy link
Collaborator

@connorjclark connorjclark commented Jan 25, 2022

This is a really sensitive bit of code, so let's have some snapshots.

Will help greatly for #13590

@connorjclark connorjclark requested a review from a team as a code owner January 25, 2022 21:57
@connorjclark connorjclark requested review from adamraine and removed request for a team January 25, 2022 21:57
@connorjclark connorjclark merged commit d6493b5 into master Jan 26, 2022
@connorjclark connorjclark deleted the flags-snapshots branch January 26, 2022 00:28
@brendankenny brendankenny mentioned this pull request Apr 19, 2022
Closed
This was referenced Jun 23, 2022
Open
Open
Open
@ryan-ally ryan-ally mentioned this pull request Jun 21, 2023
Open
@MaxMood96 MaxMood96 mentioned this pull request Jun 22, 2023
Open
This was referenced Jun 23, 2023
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@adamraine adamraine adamraine approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@adamraine adamraine

Labels

waiting4reviewer

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@connorjclark @adamraine @devtools-bot