tests: dedupe some CI job names #13549
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendankenny
commented
Jan 7, 2022
| fail-fast: false | ||
| runs-on: macos-latest | ||
| env: | ||
| # The total number of shards. Set dynamically when length of single matrix variable is |
Contributor
Author
There was a problem hiding this comment.
driveby: in this case it can be dynamic, because the matrix size is just the array of shards
connorjclark
approved these changes
Jan 7, 2022
.github/workflows/devtools.yml
Outdated
| # computable. See https://github.community/t/get-length-of-strategy-matrix-or-get-all-matrix-options/18342 | ||
| SHARD_TOTAL: 2 | ||
| name: Smoke batch ${{ matrix.smoke-test-shard }} | ||
| name: Smoke DevTools ${{ matrix.smoke-test-shard }} |
Collaborator
There was a problem hiding this comment.
nit: "DevTools smoke" or change the ordering of the other names (Ex: "Smoke windows")
Contributor
Author
There was a problem hiding this comment.
I considered that, but then we end up with DevTools / DevTools smoke or smoke / Smoke Windows haha. I guess it doesn't really matter and consistency is better :)
This was referenced Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small job name tweaks. Github actions in status checks are prefaced by their workflow name (e.g.
DevTools / web-tests) but annoyingly are not prefaced in other contexts (so you get onlyweb-tests). This is fine for some things, but I already got confused by the new "Smoke batch 1" and "Smoke batch 2" introduced in #13546.This renames them to "Smoke DevTools 1" and "Smoke DevTools 2", which will end up with a redundant "DevTools / Smoke DevTools 1" in some contexts, but I couldn't think of another good way to dedupe when it's on its own.
Also renames "Windows" to "Windows smoke" and "Windows unit".
The Github UI choices are kind of unfortunate. Things are still somewhat confusing, but at least differentiated. Super happy to bikeshed :)