• viewer needs to be updated too or its Save as HTML disappears there (example from deploy)

• Ideally we'd be able to provide a default implementation that worked in all clients, but there are some issues:

  • document.documentElement.outerHTML only works for the standalone report. If the report is embedded into some arbitrary page, this is too much.

  It would be ideal to have a default. Where is this an issue? report: introduce the new report api, add dom.rootEl #13277 introduced using rootEl.outerHTML instead of documentElement.outerHTML, but it's not entirely clear why it made the switch. PSI doesn't have the dropdown available, so it seems kind of a theoretical worry that motivated the switch to rootEl.

• needs tests! If we're going to inject these, at the very least it makes testing easy :)

It would be ideal to have a default. Where is this an issue?

If the default were grabbing the outerHTML of some element (rootEl, documentElement, etc) then our issue would be targeting the correct element for reports embedded in other pages while also getting the scripts we need. Bu an embedding page might inject the scripts in arbitrary places, so how would we get the scripts without double-including them?

If the default were using ReportGenerator, now we have the standalone report including all that extra code unnecessarily.

If the default were grabbing the outerHTML of some element (rootEl, documentElement, etc) then our issue would be targeting the correct element for reports embedded in other pages while also getting the scripts we need. Bu an embedding page might inject the scripts in arbitrary places, so how would we get the scripts without double-including them?

Yes, I was asking more literally where this is an issue :) PSI doesn't have this problem, so there's no report we support where this is an issue and we're mostly guessing what people need (tradeoff between the fiddliness of the default standalone report and supporting theoretical future users of the report API). New report test coverage is good regardless :)