Skip to content

Conversation

@paulirish
Copy link
Member

  • we havent needed conventional-changelog-cli for years
  • we havent used types/chrome since sendCommand typing got its megaupgrade
  • cpy by sindre is safe and happy

@paulirish paulirish requested a review from a team as a code owner December 10, 2021 22:25
@paulirish paulirish requested review from connorjclark and removed request for a team December 10, 2021 22:25
"c8": "^7.4.0",
"chalk": "^2.4.1",
"chrome-devtools-frontend": "1.0.922924",
"conventional-changelog-cli": "^1.3.4",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't we use it here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh damn. okay yes.

okay instead i updated it to latest. also tested that it still works well.


/**
* @return {Promise<void>}
* @return {Promise<string[]>}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove return?

@paulirish paulirish merged commit a26c8ee into master Dec 21, 2021
@paulirish paulirish deleted the devdeps branch December 21, 2021 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants