tests: clean up and add comments to cdt layout test scripts #13471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
commented
Dec 7, 2021
| export PYTHONPATH="${PYTHONPATH:-}:$BLINK_TOOLS_PATH/latest/third_party/typ" | ||
| fi | ||
|
|
||
| yarn devtools "$DEVTOOLS_PATH" |
Collaborator
Author
There was a problem hiding this comment.
perhaps yarn devtools should also just build devtools?
Contributor
There was a problem hiding this comment.
Eh it might be nice to roll LH, then change DT code without building twice.
adamraine
reviewed
Dec 8, 2021
| export PYTHONPATH="${PYTHONPATH:-}:$BLINK_TOOLS_PATH/latest/third_party/typ" | ||
| fi | ||
|
|
||
| yarn devtools "$DEVTOOLS_PATH" |
Contributor
There was a problem hiding this comment.
Eh it might be nice to roll LH, then change DT code without building twice.
adamraine
approved these changes
Dec 9, 2021
Member
|
generally lgtm. nice cleanup! one related thing that's bugged me is we have 'yarn devtools' which calls 'roll-to-devtools.sh' and then within chromium webtests we have a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some refactoring/documenting I wanted to do for these scripts.
yarn open-devtoolsif running against the default .tmp DevTools checkoutyarn open-devtools, should be useful for tests: run most smoke tests on devtools #13456