core(inspector-issues): collect all issue types #13462
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The inspector issues gatherer is now collecting all of the issues that will be reported via the devtools protocol. The tests directly related to the issues gatherer have been updated, but there are still some other tests only tangentally related that are now broken.
Contributor
Author
|
This change has broken a bunch of other tests in Sample JSON, Security, and Fraggle Rock. It would be good to get some feedback before I go and update all the tests too. |
connorjclark
requested changes
Dec 9, 2021
The inspector issues gatherer is now collecting all of the issues that will be reported via the devtools protocol. The tests directly related to the issues gatherer have been updated, but there are still some other tests only tangentally related that are now broken.
- sorted the properties of the gatherer artefact - sorted the properties of the artifact type - using 'x' in obg && obj.x && obj.x.y instead of hasOwnProperty to appease typescript - added comment on why wasmCrossOriginModuleSharingIssue is special - updated artifact property name in is-on-https test
brendankenny
changed the title
Contributor
…or gatherer changes.
…fail. - Updated the version of devtools-protocol to get the ClientHintIssueDetails definition. - Updated the chromium sync test to include the clientHintIssue - Updated the gatherer and artifact with clientHintIssue - everything else was updated based on failing unit and smoke tests
Contributor
Author
|
Updated the gatherer and updated the version of devtools-protocol to include clientHintIssueDetails and updated everything else to fix the breaking tests. @connorjclark - Do the sample artifacts get checked in too? |
Collaborator
|
Yes, but we have a command to isolate changes to the sample artifacts to just a single artifact. try this: |
connorjclark
changed the title
connorjclark
changed the title
connorjclark
approved these changes
Jan 11, 2022
Collaborator
connorjclark
left a comment
connorjclark
left a comment
There was a problem hiding this comment.
LGTM! It'll be nice to finally get back up-to-date with these.
This was referenced Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The inspector issues gatherer is now collecting all of the issues that will be reported via the devtools protocol.
The tests directly related to the issues gatherer have been updated, but there are still some other tests only tangentally related that are now broken.
Summary
This is an update to the inspector issues gatherer and audit to cover all of the issues currently reported via the devtools protocol and shown in the issues panel. Part of the goal of this change is to update the gatherer and audit to require less maintenance for future updates.
A bunch of issues have been added to the issues panel since the original lighthouse implementation.
Related Issues/PRs
Issue #13147