core(deprecations): use inspector issues #13342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
commented
Nov 9, 2021
| }, | ||
| "resolutions": { | ||
| "puppeteer/**/devtools-protocol": "0.0.939404" | ||
| }, |
Collaborator
Author
There was a problem hiding this comment.
ref: #12534 (comment)
rather add this than upgrade puppeteer in this PR
connorjclark
commented
Nov 9, 2021
| const deprecations = entries.filter(log => log.source === 'deprecation') | ||
| // TODO(M91): Temporary ignore until Chrome M91 became stable version. | ||
| // M91 doesn't throw deprecation on ::-webkit-details-marker. | ||
| .filter(log => !log.text.includes('::-webkit-details-marker')) |
Collaborator
Author
There was a problem hiding this comment.
purposefully removed this filter
adamraine
approved these changes
Nov 9, 2021
Contributor
|
can be turned back on now? |
brendankenny
reviewed
Nov 9, 2021
| }, | ||
| }; | ||
| }); | ||
| } else { |
Contributor
There was a problem hiding this comment.
does this need to be an if/else or can these be combined in one go?
Collaborator
Author
There was a problem hiding this comment.
There are some canary releases where both would be populated.
| items: [ | ||
| { | ||
| value: /'window.webkitStorageInfo' is deprecated/, | ||
| source: { |
Contributor
There was a problem hiding this comment.
is sample_v2 unchanged from the old deprecations? That ends up pretty nice
Member
nope. there's like 8 new types we don't handle. but Adam Read is working on this. |
Collaborator
Author
|
The first skipped test was enabled, b/c it is only meant to let us know when a new type exists. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix dbw smoke test.
courtesy of https://bugs.chromium.org/p/chromium/issues/detail?id=1248484