Just in case, should we clone settings, audits, and groups, too?

Could we just deep clone the entire legacy default config?

Just in case, should we clone settings, audits, and groups, too?

Could we just deep clone the entire legacy default config?

Technically the default config isn't required to be compatible with a JSON roundtrip, though since the last i18n change to IcuMessage I believe what we have is compatible. This might be the simplest and we'll have to worry a lot less about other changes down the line.

Let's just do that, and we'll count on our FR config validation and tests :)

Technically the default config isn't required to be compatible with a JSON roundtrip

If future changes to the config make it incompatible, are we guaranteed a fatal error?

No, like functions are dropped as if they never existed, which mainly affects audits and gatherers definitions (which allow Classes or instances of classes). NaN becomes null, undefined becomes nothing, so it also depends on the code using it (e.g. checking for === undefined vs checking falsy).

None of it is an apparent immediate issue but it's also not something we're looking out for on the config side of things. But in case of something being dropped we may just not notice.

@adamraine i think next action is on you here

this should be good to go to fix the immediate bug and we can add more protections later on