report(build): fix building flow report with inline-fs #13280
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendankenny
requested review from
connorjclark
and removed request for
a team
brendankenny
requested review from
adamraine
and removed request for
connorjclark
adamraine
reviewed
Oct 28, 2021
| const bundle = await rollup.rollup({ | ||
| input: 'flow-report/standalone-flow.tsx', | ||
| plugins: [ | ||
| rollupPlugins.inlineFs({verbose: true}), |
Contributor
There was a problem hiding this comment.
The files being read are not used by the flow report, so wouldn't this unnecessarily increase the size of the bundle?
Contributor
Author
There was a problem hiding this comment.
that's the 466 bytes I mentioned. It's not the files themselves, it's the locales file list. The format.js line ends up as
It=["ar-XB.json","ar.json","bg.json","ca.json","cs.json","da.json","de.json","el.json","en-GB.json","en-US.ctc.json","en-US.json","en-XA.json","en-XL.ctc.json","en-XL.json","es-419.json","es.json","fi.json","fil.json","fr.json","he.json","hi.json","hr.json","hu.json","id.json","it.json","ja.json","ko.json","lt.json","lv.json","nl.json","no.json","pl.json","pt-PT.json","pt.json","ro.json","ru.json","sk.json","sl.json","sr-Latn.json","sr.json","sv.json","ta.json","te.json","th.json","tr.json","uk.json","vi.json","zh-HK.json","zh-TW.json","zh.json"].filter((e=>e.endsWith(".json")&&!e.endsWith(".ctc.json"))).map((e=>e.replace(".json",""))).sort()another option would be changing the rollup shim to something like 'fs': 'export function readdirSync() {return []}',. The downside would be it's more fragile to future additions of fs methods 🤷
Contributor
There was a problem hiding this comment.
Ah ok, this is fine then 👍
adamraine
approved these changes
Oct 28, 2021
connorjclark
approved these changes
Oct 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the change in #13275 to unguard the
fs.readdirSyncbroke the flow report because it didn't have a call toinlineFsin the build call. This adds the plugin and fixes it.This does add 466 bytes (the list of supported locales) to the flow report that aren't used. I assume there will be better DCE when switching to es modules and rollup will be more aggressive with tree shaking?