core(build): add LH_ROOT support to inline-fs #13278
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendankenny
requested review from
connorjclark
and removed request for
a team
| } else if (node.name === '__filename') { | ||
| return filepath; | ||
| } else if (node.name === 'LH_ROOT') { | ||
| // Note: hardcoded for LH. Could be be set via inline-fs options instead. |
Collaborator
There was a problem hiding this comment.
did you want to go the extra mile and publish this plugin to npm eventually? I bet others would like to use it.
Contributor
Author
There was a problem hiding this comment.
not today but I left the comment so it would be clear there's not much to do if we ever do want to.
connorjclark
approved these changes
Oct 28, 2021
Collaborator
connorjclark
left a comment
connorjclark
left a comment
There was a problem hiding this comment.
Next I was planning on adding source map and watch file support, but I believe #12771 should be good to go after this PR @connorjclark?
Yup, this should be the last piece needed to finish up that PR!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #13231
lets inline-fs replace
LH_ROOTwith the value ofLH_ROOT. I expected this PR to have more but the locale replacement stuff had to move to #13275Support is hardcoded into inline-fs rather than plumbing through options because it's only one custom thing and we've never really needed anything else out of
brfs. If the number of identifiers (or whatever) needing to be replaced grows in the future we can always add it later (just say no to magic bundler syntax though :).Next I was planning on adding source map and watch file support, but I believe #12771 should be good to go after this PR @connorjclark?