Skip to content

misc(build): use cross platform sed for devtools script #13242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
paulirish merged 3 commits into from
Oct 21, 2021
Merged

misc(build): use cross platform sed for devtools script #13242

paulirish merged 3 commits into from
Oct 21, 2021

Conversation

@paulirish
Copy link
Member

@paulirish paulirish commented Oct 21, 2021

Running yarn open-devtools locally, i get an error:

../../front_end/panels/lighthouse/LighthousePanel.ts(266,38): error TS2339: Property 'DOM' does not exist on type 'typeof import("lighthouse/.tmp/chromium-web-tests/devtools/devtools-frontend/out/Default/gen/front_end/third_party/lighthouse/report/report")'.

In #12933 we added a fix for this, but the sed command was invalid.
And since the script didnt have a euo pipefail the script continued despite this happening:

+ npx tsc --allowJs --declaration --emitDeclarationOnly dist/report/bundle.esm.js
+ sed -i '' 's/export type DOM = any;//' dist/report/bundle.esm.d.ts
sed: can't read s/export type DOM = any;//: No such file or directory

(found all this while debugging some CI devtools failures in #13123)

@paulirish paulirish requested a review from a team as a code owner October 21, 2021 17:25
@paulirish paulirish requested review from adamraine and removed request for a team October 21, 2021 17:25
@google-cla google-cla bot added the cla: yes label Oct 21, 2021
@paulirish
Copy link
Member Author

paulirish commented Oct 21, 2021

thanks for looking. it appears this PR is still broken (in two ways). uno momento. :)

@paulirish paulirish mentioned this pull request Oct 21, 2021
Merged
@paulirish
Copy link
Member Author

paulirish commented Oct 21, 2021 •
edited
Loading

two latest commits explained

unbound variable: https://github.com/GoogleChrome/lighthouse/pull/13123/files/44ecdeca4e3549bdd2e481dbf4dcf50ae7a0ccf0#r733926471

also.. other unbound variable bs: #11331 #11809 #11845

sed -i BS: https://github.com/GoogleChrome/lighthouse/pull/13123/files/44ecdeca4e3549bdd2e481dbf4dcf50ae7a0ccf0#r733929051

connorjclark
connorjclark reviewed Oct 21, 2021
View reviewed changes
@connorjclark connorjclark changed the title clients(devtools): fix tsc workaround sed typo misc(build): use cross platform sed for devtools script Oct 21, 2021
@paulirish paulirish merged commit cbc9282 into master Oct 21, 2021
@paulirish paulirish deleted the tscdom branch October 21, 2021 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@connorjclark connorjclark connorjclark approved these changes

+1 more reviewer

@adamraine adamraine adamraine approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@adamraine adamraine

Labels

cla: yes waiting4reviewer

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@paulirish @connorjclark @adamraine @devtools-bot