-
Notifications
You must be signed in to change notification settings - Fork 9.6k
tests: make yarn unit run all available unit tests #13148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
well, these are covered by Context here is that #13146 is adding yet another directory with tests in it, and I don't really have any interest in adding a |
|
rather than make |
1a594bf to
4765bf3
Compare
|
updated with docs test changes from #13150 so Also moved the
|
|
ในวันที่ ศ. 1 ต.ค. 2021 04:19 น. devtools-bot ***@***.***>
เขียนว่า:
… Merged #13148 <#13148>
into master.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#13148 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/APZGLUSXV7HOQW76I2VY4W3UETH47ANCNFSM5FBDOQ7Q>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
we keep growing
yarn unitby adding every newyarn unit-*, butjest.config.jshas to have references to these files anyways, soyarn jestworks just fine if you just want to run all the unit tests :)This also fixes some overlaps and cracks between the
yarn unit-*s. The currentyarn unitdoesn't runclients/test/extension/popup-test.jsclients/test/extension/settings-controller-test.jsclients/test/lightrider-entry-test.jsdocs/recipes/integration-test/example-lh-auth.test.jsthird-party/chromium-synchronization/inspector-issueAdded-types-test.jsthird-party/chromium-synchronization/installability-errors-test.jsthe last two might be on purpose but seems like they should be in the testing path if the goal is for changes in Canary to alert us to needed updates? It also made us miss that the path to
LH_ROOTwas wrong ininspector-issueAdded-types-test.jsand it doesn't run at all.We're also running the
flow-reporttests twice because they're picked up by bothyarn unit-reportandyarn unit-flow.This is most important in CI, where unit.yml runs them via
yarn unit:ciand should be running all the tests.