report: add adornment to audit description when not scored #13014
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
requested review from
patrickhulce
and removed request for
a team
Collaborator
Author
|
I considered adding an adornment when there is a weight>1 that said how much the audit counts towards the category score .... but there lies i18n dragons |
patrickhulce
approved these changes
Sep 7, 2021
Collaborator
patrickhulce
left a comment
patrickhulce
left a comment
There was a problem hiding this comment.
LGTM though I'd love @Jiwoong or @paulirish 's eyes on it as well
Collaborator
Author
|
Thoughts on this approach? Do people this this will help users not make the mistake of thinking various audits in Performance category (or the odd one in other categories) impact the category score directly? |
paulirish
approved these changes
Jun 11, 2025
Collaborator
Author
|
paul loves this. will update and land soon |
connorjclark
force-pushed
the
unscored-report
branch
from
c4a68f3 to
01d558c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The scored / not-scored confusion happens occasionally. this could help
temporary fix to address most concerns in #12996