report(flow): sidebar mocks #13002
Merged
report(flow): sidebar mocks #13002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
approved these changes
Sep 2, 2021
flow-report/src/icons.tsx
Outdated
|
|
||
| export const SummaryIcon: FunctionComponent = () => { | ||
| return ( | ||
| <svg width="14" viewBox="0 0 18 16" fill="none" xmlns="http://www.w3.org/2000/svg"> |
Collaborator
There was a problem hiding this comment.
we learned in #12803 that xmlns is unnecessary in svg-in-HTML, so we can remove.
was the svg run through https://jakearchibald.github.io/svgomg/ ?
Contributor
Author
There was a problem hiding this comment.
was the svg run through https://jakearchibald.github.io/svgomg/ ?
No
satya-nutella
pushed a commit
to satya-nutella/lighthouse
that referenced
this pull request
Sep 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the sidebar to resemble our mocks better.
There isn't much included in the runtime settings, and the information be visible on the individual reports, so we could leave that out for now.