report(flow): summary page #12973
report(flow): summary page #12973
Conversation
patrickhulce
left a comment
patrickhulce
left a comment
There was a problem hiding this comment.
nice! great covering a lot of ground here
| className="SummaryFlowStep__screenshot" | ||
| data-testid="SummaryFlowStep__screenshot" | ||
| src={screenshot || undefined} | ||
| style={{width: THUMBNAIL_WIDTH, maxHeight: thumbnailHeight}} |
There was a problem hiding this comment.
just set the height explicitly and rely on object-fit?
There was a problem hiding this comment.
That cuts off part of the screenshot if it doesn't fit the aspect ratio of the emulated device screen. Navigation screenshots were this way before I switched to FPS.
Ultimately this is a bug with how the screenshots are collected, but I still think we should leave this as maxHeight in case they pop up again.
There was a problem hiding this comment.
Gotcha, do we have an issue or entry in #11313 to tackle the screenshot bug you mention?
| "@firebase/auth-types": "0.3.2", | ||
| "@firebase/util": "0.2.1", | ||
| "@rollup/plugin-node-resolve": "^13.0.4", | ||
| "@rollup/plugin-typescript": "^2.1.0", |
There was a problem hiding this comment.
haha, sounds good, but let's work to find a better reason for the perf packet later ;)
5 participants
Still a bit messy, and I haven't started the tests yet. Wanted to get some initial thoughts on the structure / looks before I finish up.
Gaugeis an example of a component imported from the normal report renderer.