Skip to content

core(network-request): identify filesystem resources as non-network #12970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
patrickhulce merged 4 commits into from
Aug 23, 2021
Merged

core(network-request): identify filesystem resources as non-network #12970

patrickhulce merged 4 commits into from
Aug 23, 2021

Conversation

@patrickhulce
Copy link
Collaborator

@patrickhulce patrickhulce commented Aug 23, 2021 •
edited
Loading

Summary
Closes three holes in our isNonNetworkRequest logic:

  1. file protocol URLs were considered network requests.
  2. filesystem protocol URLs were considered network requests. (it's different!)
  3. When requests are blocked or otherwise don't receive a response the protocol field is left empty and requests weren't identified as non-network.

Related Issues/PRs
fixes #12915

@patrickhulce patrickhulce requested a review from a team as a code owner August 23, 2021 17:07
@patrickhulce patrickhulce requested review from adamraine and removed request for a team August 23, 2021 17:07
@google-cla google-cla bot added the cla: yes label Aug 23, 2021
@connorjclark
Copy link
Collaborator

connorjclark commented Aug 23, 2021 •
edited
Loading

what about filesystem? https://github.com/GoogleChrome/lighthouse/pull/12920/files#diff-2302fa8968cce5aae24372b1b88c1e2927f40626f261646064b57d4434840066R23

@patrickhulce
Copy link
Collaborator Author

patrickhulce commented Aug 23, 2021 •
edited
Loading

@connorjclark in practice I was never able to observe filesystem actually be populated in these cases were you?

All file: URLs were blocked immediately in my tests which triggers the empty protocol branch. EDIT: filesystem is completely different from file got it 👍

We definitely have a larger issue lurking here with protocol and scheme being used interchangeably throughout the codebase even though they can be quite different (h2 vs. https). I'll file an issue for that 👍

@patrickhulce patrickhulce merged commit d982a31 into master Aug 23, 2021
@patrickhulce patrickhulce deleted the file_protocol_nonnetwork branch August 23, 2021 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@adamraine adamraine adamraine approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@adamraine adamraine

Labels

cla: yes waiting4reviewer

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Local Resources(file:///) highlighted as Render Blocking Resources

4 participants

@patrickhulce @connorjclark @adamraine @devtools-bot