core(fr): parity on Stacks and FullPageSnapshot gatherers #12907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickhulce
requested review from
connorjclark
and removed request for
a team
8 tasks
Comment on lines
14
to
16
| // Number of network requests differs between Fraggle Rock and legacy modes because | ||
| // FR has fewer passes, preserve this check in legacy mode only. | ||
| _legacyOnly: true, |
Contributor
There was a problem hiding this comment.
should the count be updated and be _fraggleRockOnly? It took us a while to figure out the re-requests and seems like it might be important to catch FR runner regressions (re: #11506)?
Collaborator
Author
There was a problem hiding this comment.
sure I'll do it that way instead 👍
Contributor
|
pretty amazing dbw works! 🎉 |
connorjclark
approved these changes
Aug 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Achieves parity with legacy runner on Stacks gatherer and FullPageSnapshot gatherer (the two necessary to match results on the dobetterweb smoketest). This also adds the ability to target assertions to the legacy or FR runner in smoketests to account for irreconcilable differences like fewer passes and extra contexts that change the ID of certain artifacts.
Related Issues/PRs
ref #12861 #11313