Skip to content

misc(build): normalize sample-report build naming #12901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
devtools-bot merged 2 commits into from
Aug 12, 2021
Merged

misc(build): normalize sample-report build naming #12901

devtools-bot merged 2 commits into from
Aug 12, 2021

Conversation

@paulirish
Copy link
Member

@paulirish paulirish commented Aug 10, 2021 •
edited
Loading

currently based off PR #12815

stemming from this thread #12815 (comment)

  • build-dist-reports => build-sample-reports
    • no strong feelings. seems good and lines up with samplev2 which makes sense
  • build-report-for-autodeployment.js ⟶ build/build-sample-reports.js
    • rename and relocation. feels good. i use this locally to test report stuff (so its not just about the autodeployment for me)
  • now-build -> vercel-build
    • the vercel deployments rely on this convention. we could tell vercel to use a custom build command in their UI, but i kinda prefer continuing to use the convention. seems like they've been supporting the now- name, but might as well update it

tag #12879 as its slightly related.

@google-cla google-cla bot added the cla: yes label Aug 10, 2021
connorjclark
connorjclark approved these changes Aug 10, 2021
View reviewed changes
Copy link
Collaborator

@connorjclark connorjclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (but land as separate commit)

Base automatically changed from faux-psi to master August 11, 2021 22:39
@paulirish paulirish force-pushed the buildreportrenammes branch from 391e322 to 8b23506 Compare August 12, 2021 17:54
@paulirish paulirish mentioned this pull request Aug 12, 2021
Merged
@paulirish paulirish marked this pull request as ready for review August 12, 2021 18:00
@paulirish paulirish requested a review from a team as a code owner August 12, 2021 18:00
@paulirish paulirish requested review from patrickhulce and removed request for a team August 12, 2021 18:00
@devtools-bot devtools-bot merged commit 4f349bd into master Aug 12, 2021
@devtools-bot devtools-bot deleted the buildreportrenammes branch August 12, 2021 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@connorjclark connorjclark connorjclark approved these changes

@patrickhulce patrickhulce Awaiting requested review from patrickhulce

Assignees

@patrickhulce patrickhulce

Labels

cla: yes waiting4reviewer

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@paulirish @connorjclark @patrickhulce @devtools-bot