misc: npmignore all of dist/ except standalone report #12855
Conversation
.npmignore
Outdated
|
|
||
| # generated files needed for publish | ||
| dist/* | ||
| dist/report/* |
There was a problem hiding this comment.
this lets us ignore the other files in dist/report/, which I assume we want to do
npm notice 177.4kB dist/report/bundle.js
npm notice 165.6kB dist/report/psi.js
npm notice 74.7kB dist/report/standalone.js
npm notice 12.3kB dist/report/treemap.js
npm notice 188.3kB dist/report/viewer.js 
connorjclark
left a comment
connorjclark
left a comment
There was a problem hiding this comment.
wondering how this works, reading the docs (and making the assumption that npmignore works like gitignore) ...
From my reading of this page, nothing suggests the behavior we saw. This is the closest related thing mentioned:
[... about the !include negation pattern ...] It is not possible to re-include a file if a parent directory of that file is excluded. Git doesn’t list excluded directories for performance reasons, so any patterns on contained files have no effect, no matter where they are defined.
While I find this paragraph difficult to parse, I don't think it explains the behavior we saw, which is basically "negating a file inside a directory that has been ignored will unignore the directory"
|
Yeah, the docs aren't clear at all. It's more like if re-including a file the parent directory is no longer ignored.
But seriously, the explanations on that page are terrible :) |
4 participants
fixes #8084
we have to explicitly ignore
dist/*(not justdist/) to then be able to unignoredist/report/standalone.js