Skip to content

Conversation

@adamraine
Copy link
Contributor

@adamraine adamraine commented Aug 3, 2021

Basic shell for a FR flow report. It doesn't actually render the report, I'm hoping to use the updated renderer API for that part #12772.

In the meantime we can work on the flow UX items like the sidebar and summary page.

Example report: https://gist.github.com/adamraine/7bf5b5b3c8a3f08cbf1226cddaeff078

Ref #11313

@google-cla

This comment has been minimized.

@google-cla google-cla bot added the cla: no label Aug 3, 2021
@connorjclark
Copy link
Collaborator

connorjclark commented Aug 3, 2021

Can you add the result to lighthouse-core/scripts/build-report-for-autodeployment.js so we can easily preview it? Not much to see now I know, but might as well set it up for the near future.

Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had quite a hand in most of this, so I'm most interested in other folks feedback :)

but tsx sounds great to me!

Co-authored-by: Patrick Hulce <[email protected]>
@google-cla

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants