core(byte-efficiency): mark n/a if no network records in timespan #12839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamraine
changed the title
patrickhulce
approved these changes
Jul 31, 2021
|
|
||
| // TODO(FR-COMPAT): Reduce this number by handling the error, making N/A, or removing timespan support. | ||
| expect(erroredAudits.length).toMatchInlineSnapshot(`14`); | ||
| expect(erroredAudits.length).toMatchInlineSnapshot(`1`); |
Contributor
Author
There was a problem hiding this comment.
long-tasks. It's not a byte efficiency audit but requests the page dependency graph, which throws an error when there are no network records. It requires some additional investigation before we decide to just mark as N/A.
lighthouse-core/audits/byte-efficiency/byte-efficiency-audit.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Patrick Hulce <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves most of the errors we were seeing for a timespan run after page load.
The solution is to mark all BE audits N/A if there were no network records in timespan mode. Conceptually, this makes some sense since ms savings are calculated from throughput in timespan mode.
Possible improvement:
Not all BE audits require network records. It was
LoadSimulator, used to calculate throughput savings for all BE audits, which requires network records. Instead of always returning N/A, we could get throughput from the settings when using DT or simulated throttling, but not provided throttling. Provided throttling would need to be N/A without network records in timespan mode.