misc(build): ensure distDir is present before emptying it #12829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulirish
changed the title
adamraine
approved these changes
Jul 27, 2021
|
|
||
| fs.mkdirSync(distDir, {recursive: true}); // Ensure dist is present, else rmdir will throw | ||
| fs.rmdirSync(distDir, {recursive: true}); | ||
| fs.mkdirSync(distDir); |
Collaborator
There was a problem hiding this comment.
Instead we can use fs.rmSync with force: true and recursive: true.
Contributor
There was a problem hiding this comment.
rm/rmSync aren't supported until Node 14
Member
Author
There was a problem hiding this comment.
rmSync is new in node 14. (not in 12). :/
fsPromises.rmdir has force, but will require a bigger diff in this file.rm method in sync or promises versions. both need node 14.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #12800 ( i could repro )