tests: add report/ to tsconfig #12822
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
commented
Jul 22, 2021
| @@ -1,6 +1,5 @@ | |||
| **/node_modules/** | |||
| **/third_party/** | |||
| **/generated/** | |||
Collaborator
Author
There was a problem hiding this comment.
drive-by removal of generated which was actually cut before going to master
Contributor
There was a problem hiding this comment.
Looks like this was hiding eslint errors in lighthouse-core/lib/cdt/generated/SourceMap.js. Maybe just make this rule specific to that directory?
connorjclark
commented
Jul 22, 2021
report/clients/treemap.js
Outdated
| import {Logger} from '../renderer/logger.js'; | ||
| import {TextEncoding} from '../renderer/text-encoding.js'; | ||
|
|
||
| /** @typedef {import('../../lighthouse-treemap/types/treemap')} */ |
Collaborator
Author
There was a problem hiding this comment.
was pleasantly surprised this worked
EDIT: except it works too well.... this pollutes the window everywhere in lighthouse-core,cli. oops. @brendankenny any ideas, or just ts-expect-error? These files are rather temporary if the report refactor works out...
adamraine
approved these changes
Aug 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forgot to add this folder to the tsconfig during #12690
Tests remain un-(type-)checked.