report(metric-filter): handle multiple reports in the same DOM #12817
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
connorjclark
left a comment
connorjclark
left a comment
There was a problem hiding this comment.
need #12815 for full review
Member
Author
|
setting back to draft. need #12815 especially since right i'm not seeing tabbing behavior that makes any sense in that testpage... 😖 also.. relevant resource on the topic: https://www.sarasoueidan.com/blog/inclusively-hiding-and-styling-checkboxes-and-radio-buttons/ |
brendankenny
reviewed
Aug 3, 2021
Member
Author
In the meantime, here's the combo: https://famous-horses.surge.sh/%E2%8C%A3.psi.english/index.html |
connorjclark
approved these changes
Aug 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes a bug that's live in PSI
found by adam in #12815 (comment)
also by sidverma32. fixes #12725
reviewer: the big change is using a checkbox inside of
<label>instead of relying onid&forattributes.