deps: update lighthouse-logger to 1.3.0 #12812
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendankenny
approved these changes
Jul 20, 2021
Contributor
brendankenny
left a comment
brendankenny
left a comment
There was a problem hiding this comment.
LGTM
hopefully no one out there is parsing those logs too strictly :)
Collaborator
|
You'll need to update the devtools tests. |
Collaborator
Author
How does one do that in their broken state? Also, which part? The scope isn't actually part of our expectations, just the message |
Collaborator
|
oh, forgot to land #12807 should be good now.
ah, I thought there'd be a log output change. nvm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes the wart introduced by #12805 and bumps our use of lighthouse-logger to be prefixed with
LH:Related Issues/PRs
ref #11313 #12805