core(fr): support config filtering via only/skip settings #12808
Conversation
Co-authored-by: Adam Raine <[email protected]>
| notApplicableAudits, | ||
| } = getAuditsBreakdown(lhr); | ||
| // TODO(FR-COMPAT): This assertion can be removed when full compatibility is reached. | ||
| expect(auditResults.length).toMatchInlineSnapshot(`59`); |
There was a problem hiding this comment.
I don't understand why this went down. There are no explicit filters for the timespan tests right?
There was a problem hiding this comment.
ah sorry forgot to comment, this went down because we now filter the config by default of any audits that aren't included in any categories (except full-page-screenshot). the manual audits in a11y were all trimmed because we had logic that didn't display them, but nothing that removed their JSON from the payload.
|
|
||
| // Some audits are used by the report for additional information. | ||
| // Keep these audits unless they are *directly* skipped with `skipAudits`. | ||
| const filterResistantAuditIds = ['full-page-screenshot']; |
There was a problem hiding this comment.
One of the TODOs you removed mentioned Stacks, it's not a base artifact in FR. Should we include here?
There was a problem hiding this comment.
Ah, that TODO was actually solved by a previous update to filtering, but the TODO was missed in another file :)
This is a set of audit IDs that should be kept even if they're not in the onlyAudits/onlyCategories list. Extra artifacts are never kept unless they are base artifacts.
3 participants
Summary
Implements the
onlyAudits/onlyCategories/skipAuditsfunctionality for the FR config. This will unlock smoketest running in FR navigation runner.Related Issues/PRs
ref #12805 #11313