core(dom): introduce safelySetHref #12796
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
patrickhulce
left a comment
patrickhulce
left a comment
There was a problem hiding this comment.
impl sg we're not losing much, just some tests lacking :)
…estricted-properties" This reverts commit a1b29a7.
| it('gets full HTML snippet', () => { | ||
| assert.equal(pageFunctions.getOuterHTMLSnippet( | ||
| dom.createElement('div', '', {id: '1', style: 'style'})), '<div id="1" style="style">'); | ||
| const elem = dom.createElement('div'); |
Contributor
There was a problem hiding this comment.
wow, dom.js in here. I even thought it looked "pretty handy" to have in here in the original review :)
I feel like it shouldn't be crossing out of the report anymore. Since it's equivalent to document.createElement() calls now, do you mind cutting out dom.js now?
patrickhulce
approved these changes
Jul 19, 2021
2 tasks
| assert = (await import('assert')).strict; | ||
| jsdom = await import('jsdom'); | ||
| pageFunctions = (await import('../../lib/page-functions.js')).default; | ||
| DOM = (await import('../../../report/renderer/dom.js')).DOM; |
Collaborator
There was a problem hiding this comment.
totally didnt notice the DOM usage here was trivial :P
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
safelySetHrefand change allelem.hrefsetters to use it. it ensures we don't set a link to ajavascript:evil()url.safelySetBlobHref. same kinda idea.attrsmethod signature from createElement. it opens another vector towards accidentally setting href/src/etc to something bad. it was unlikely, but that syntactic sugar didn't really save us much. :)Relevant to cl/383899920 🔒