misc: get LH_ROOT via new file root.js #12724
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Any chance we can use module aliases? |
Collaborator
Author
|
adamraine
approved these changes
Jun 30, 2021
Contributor
brendankenny
left a comment
brendankenny
left a comment
There was a problem hiding this comment.
this looks good, but I'm not a huge fan of root.js, especially if it grows to have dirname/filename substitutes. I don't have a better suggestion than my pretty bad module-utils.js one, though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces all the
LH_ROOT = '../../../'madness withconst {LH_ROOT} = require('../../../root.js'). This does a few things:LH_ROO+<enter>to auto-import this value to a file__dirname, so having the code in one place means less future boilerplate)Beyond changing all instances of
LH_ROOT = ..., I also grokked for lines that use__dirnameto form a path that goes to the root, and changed them to useLH_ROOT.I did not modify any files that use
__dirnamew/o crossing over the root directory (ex:report-assets.jsdoes__dirname + '/renderer/util.js')–I have some ideas for that, maybe worth discussing here:getRelativePathEsm(importMeta, ...pathSegments)(usage:getRelativePathEsm(import.meta, 'somefile.json'))root.jscould also export all the top-level directories (LH_CORE,LH_CLI, etc...)LH_ROOTfor everything, and have all paths used in code be relative to root( the motivation is to avoid this code everywhere https://stackoverflow.com/a/50052194/2788187 )