Skip to content

tests: tweak variability assertion for load-things transferSize #12701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
devtools-bot merged 1 commit into from
Jun 25, 2021
Merged

tests: tweak variability assertion for load-things transferSize #12701

devtools-bot merged 1 commit into from
Jun 25, 2021

Conversation

@paulirish
Copy link
Member

@paulirish paulirish commented Jun 25, 2021 •
edited
Loading

This upstreams a change created by the JS web build team. 🔒 http://cl/379821904 THANK YOU to Elena and Jan! 😻

As noted by them:

For the document resource: the new transfer size is just outside current bounds of '2200±100'
The transfer size differences appear to be caused by header changes (where with the node14 upgrade, there is an additional header, Keep-Alive: timeout=5).

@paulirish paulirish requested a review from a team as a code owner June 25, 2021 01:59
@paulirish paulirish requested review from connorjclark and removed request for a team June 25, 2021 01:59
@google-cla google-cla bot added the cla: yes label Jun 25, 2021
@devtools-bot devtools-bot merged commit 168ef7e into master Jun 25, 2021
@devtools-bot devtools-bot deleted the transfersize branch June 25, 2021 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@connorjclark connorjclark connorjclark approved these changes

Assignees

@connorjclark connorjclark

Labels

cla: yes waiting4reviewer

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@paulirish @connorjclark @devtools-bot