tests: add explicit small-icu detection for i18n #12696
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendankenny
commented
Jun 24, 2021
| function isNode12SmallIcu() { | ||
| // COMPAT: Remove when Node 12 is retired and `full-icu` is the default everywhere. | ||
| return process.versions.node.startsWith('12') && | ||
| Intl.NumberFormat.supportedLocalesOf('es').length === 0; |
Contributor
Author
There was a problem hiding this comment.
good enough check. We really only need to know if the host machine is going to fail an i18n test so needs to go onto the easy-mode test instead
patrickhulce
approved these changes
Jun 25, 2021
Contributor
|
Works for me! |
paulirish
approved these changes
Jun 25, 2021
brendankenny
force-pushed
the
small-icu-test
branch
from
b155cf0 to
7be39fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the node 12 compat checks added to unit tests in #12426 don't work if your Node 12 also happened to be built with
full-icu, as @victorporof's seems to have been :)This adds an explicit check for better-than-small ICU support to the existing node 12 checks. As before, we can remove all this when we move to a Node 14 minimum.