Skip to content

Conversation

@G-Rath
Copy link
Contributor

@G-Rath G-Rath commented Jun 9, 2021

Summary

This is an initial "let's go for it" attempt to upgrade ws to see what breaks.

Related Issues/PRs

Resolves #12637

@google-cla google-cla bot added the cla: yes label Jun 9, 2021
@patrickhulce patrickhulce changed the title fix: update ws to latest deps: update ws to latest Jun 9, 2021
@patrickhulce
Copy link
Collaborator

Thanks @G-Rath! Nothing jumped out to me in the breaking changes list that should affect us. Our usage of ws is pretty limited just to receive messages and reject on socket close. It's possible a few of the socket error re-emit changes affect us, but not in a way that I know enough to object to.

Let's see if anything breaks :)

@G-Rath G-Rath marked this pull request as ready for review June 9, 2021 18:39
@G-Rath G-Rath requested a review from a team as a code owner June 9, 2021 18:39
@G-Rath G-Rath requested review from adamraine and removed request for a team June 9, 2021 18:39
@G-Rath
Copy link
Contributor Author

G-Rath commented Jun 9, 2021

@patrickhulce that sounds good to me!

@adamraine adamraine merged commit cacf135 into GoogleChrome:master Jun 9, 2021
@G-Rath G-Rath deleted the update-ws branch June 9, 2021 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Current version of ws dependency is vulnerable

4 participants