misc: npmignore larger unnecessary files #12627
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
going through our npm packed files, a few more large ones jumped out that aren't needed for a production run (basically all the files >100KiB that aren't a locale file):
docs/sd-validation/npmignoring these saves about 1MiB in our installed package size (package size: 2.5 MB -> 2.2 MB, unpacked size: 12.6 MB -> 11.6 MB).
I never go into an installed package to get docs about that package (I go to
npmor direct to the repo), but if that is a use case worth preserving we could ignore justdocs/recipes/and keep the changelog and still get like half of the savings.