Skip to content

core(fr): convert script-elements gatherer #12621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adamraine merged 3 commits into from
Jun 4, 2021
Merged

core(fr): convert script-elements gatherer #12621

adamraine merged 3 commits into from
Jun 4, 2021

Conversation

@adamraine
Copy link
Contributor

@adamraine adamraine commented Jun 4, 2021

This would be affected by #12619 but there are no type errors right now so we don't need to wait.

Ref #11313

@adamraine adamraine requested a review from a team as a code owner June 4, 2021 19:23
@adamraine adamraine requested review from patrickhulce and removed request for a team June 4, 2021 19:23
@google-cla google-cla bot added the cla: yes label Jun 4, 2021
patrickhulce
patrickhulce approved these changes Jun 4, 2021
View reviewed changes
Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@adamraine adamraine merged commit 27f73cd into master Jun 4, 2021
@adamraine adamraine deleted the fr-script-elements branch June 4, 2021 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@patrickhulce patrickhulce patrickhulce approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@patrickhulce patrickhulce

Labels

cla: yes waiting4committer

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@adamraine @patrickhulce @devtools-bot