tests(report): increase timeout for running axe on report renderer #12610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ae103cf.
patrickhulce
approved these changes
Jun 3, 2021
Collaborator
patrickhulce
left a comment
patrickhulce
left a comment
There was a problem hiding this comment.
Oddly, the explicit 10s timeout isn't being honored locally, and appears to only be honored in CI intermittently.
Regardless, this test definitely takes >10s locally despite having a timeout set for that.
Timeouts are only honored at task boundaries. It's been a while since I've profiled axe, but if it yields after a smaller chunk of work (that takes <10s locally but >10s in CI), and then does a more work before resolving without yielding then that would explain this behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently master branch is failing due to this error.
https://github.com/GoogleChrome/lighthouse/runs/2731679275#step:10:376
Oddly, the explicit 10s timeout isn't being honored locally, and appears to only be honored in CI intermittently.
Regardless, this test definitely takes >10s locally despite having a timeout set for that.
Let's give the test the breathing room it needs.
--
Also btw i profiled this test and... yeah its a bunch of axe+jsdom interaction. I don't expect we can do much about it until we move off jsdom.