core(csp-xss): add severity text column to report #12551
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
connorjclark
left a comment
connorjclark
left a comment
There was a problem hiding this comment.
seems good to me, but we can discuss in eng meeting
connorjclark
approved these changes
May 25, 2021
paulirish
reviewed
May 25, 2021
Member
paulirish
left a comment
paulirish
left a comment
There was a problem hiding this comment.
one thing i'll raise before we merge it…
patrickhulce
approved these changes
May 25, 2021
Collaborator
patrickhulce
left a comment
patrickhulce
left a comment
There was a problem hiding this comment.
Communicating the severity within the audit SGTM, IIRC most of my thoughts here were around communication of the severity of the audit as a whole, which this doesn't touch yet 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on the web.dev documentation, I thought it would be useful to map the section headers to severity indicators in the report. Our last discussion on this ruled out using icons, but I would like to gauge interest in a simple text value. Documentation elaborates on the meaning of "High" and "Medium".