core(navigate): only observe longtasks in PerfObserver #12545
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
approved these changes
May 24, 2021
Collaborator
connorjclark
left a comment
connorjclark
left a comment
There was a problem hiding this comment.
Buffered flag only works when you use type not, entryTypes.
wut
Member
yup. super subtle thing with the PO. if you wanna use |
Member
|
The console was emitting a warning when we were running this, but we weren't listening for any messages…
edit: AH, that's what tipped us off. phew. |
paulirish
approved these changes
May 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Buffered flag only works when you use
typenot,entryTypes. It's not really a regression when we turned it on, because we just fell back to the same behavior as before we added it a few weeks ago, but this will make the fix actually work :) (we never really needed buffered either, mostly an extra boost of wait condition correctness in ultrarare cases where entries weren't emitted fast enough)Related Issues/PRs
fixes #12544