core(fr): convert inspector-issues gatherer #12530
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamraine
commented
May 20, 2021
Comment on lines
54
to
56
| if (!process.env.CHROME_PATH) throw Error('CHROME_PATH is not set'); | ||
| browser = await puppeteer.launch({ | ||
| executablePath: process.env.CHROME_PATH, |
Contributor
Author
There was a problem hiding this comment.
Audits CDP domain is not available in the Chromium which ships with our current puppeteer.
Collaborator
Contributor
Author
There was a problem hiding this comment.
Should be good now.
Collaborator
patrickhulce
left a comment
patrickhulce
left a comment
There was a problem hiding this comment.
nice! you're flying through these 😃
Comment on lines
54
to
56
| if (!process.env.CHROME_PATH) throw Error('CHROME_PATH is not set'); | ||
| browser = await puppeteer.launch({ | ||
| executablePath: process.env.CHROME_PATH, |
Collaborator
patrickhulce
approved these changes
May 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #11313