i18n: import #12515
i18n: import #12515
Conversation
| "message": "غير معروف" | ||
| }, | ||
| "lighthouse-core/report/html/renderer/util.js | showRelevantAudits": { | ||
| "message": "Show audits relevant to:" |
There was a problem hiding this comment.
uhhhh? do we need to mark this as bad?
There was a problem hiding this comment.
doesn't look good but I think that setup with that string is already rough for rtl i18n (anything ending with a colon and saying "this stuff here"), maybe that's why it was skipped?
There was a problem hiding this comment.
Don't think it was skipped for that reason, or at least others weren't (ca/Catalan is ltr but was skipped).
There was a problem hiding this comment.
yeah I found all the util.js german ones were just skipped.
| "message": "Desconegut" | ||
| }, | ||
| "lighthouse-core/report/html/renderer/util.js | showRelevantAudits": { | ||
| "message": "Show audits relevant to:" |
There was a problem hiding this comment.
same...
prob tons more, should we have a test that the non-en strs don't === the en strs?
patrickhulce
left a comment
patrickhulce
left a comment
There was a problem hiding this comment.
behavior is the same with the english ones, so doesn't seem to hurt anything at least.
| "message": "Warnungen: " | ||
| }, | ||
| "lighthouse-treemap/app/src/util.js | allLabel": { | ||
| "message": "All" |
There was a problem hiding this comment.
seems like all of the utils just weren't translated
|
all strings are filled out by the tc dump, but it uses |
4 participants
No description provided.