Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new_audit: structured data validation using shex #12324

Closed

Conversation

gnomus043
Copy link

This PR introduces a structured data (seo) audit, which is based on ShEx validation language. Currently, the audit is based on ShEx shapes, which are close to Schema.org constraints and also include prototypes of service-specific shapes, close to oficial Bing, Google, Pinterest and Yandex requirements.
Background document, that is briefly describing core part of this audit.
Currently this PR is a draft PR and is not ready for checking in, but we would be grateful for any feedback

Gnomus042 and others added 2 commits March 31, 2021 08:55
new structured data fork created due to significant differences and problems with history. Old fork: https://github.com/Gnomus042/lighthouse
@google-cla
Copy link

google-cla bot commented Apr 2, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@connorjclark
Copy link
Collaborator

This is a lot of work to get right, and we don't have the resources to pursue this now. In short, some non-starters are how big the dependencies are, and how long this takes to process. There is a possible future where this will be perfect as a Lighthouse plugin (which is a project somewhat on the backburner).

We're thankful for the effort put towards this so far, it will surely be useful if this is ever picked up again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants