Skip to content

tests(smoke): ignore lantern script attribution in ToT #12256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adamraine merged 1 commit into from
Mar 18, 2021
Merged

tests(smoke): ignore lantern script attribution in ToT #12256

adamraine merged 1 commit into from
Mar 18, 2021

Conversation

@adamraine
Copy link
Contributor

@adamraine adamraine commented Mar 17, 2021

Quick bypass that should unblock #12255 and the release process.

@adamraine adamraine requested a review from a team as a code owner March 17, 2021 23:53
@adamraine adamraine requested review from paulirish and removed request for a team March 17, 2021 23:53
@google-cla google-cla bot added the cla: yes label Mar 17, 2021
@brendankenny
Copy link
Contributor

brendankenny commented Mar 18, 2021

Problem is tracked in https://crbug.com/1189705

brendankenny
brendankenny approved these changes Mar 18, 2021
View reviewed changes
Copy link
Contributor

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@adamraine adamraine mentioned this pull request Mar 18, 2021
Closed
@adamraine adamraine merged commit b571ab6 into master Mar 18, 2021
@adamraine adamraine deleted the lantern-smoke-fix branch March 18, 2021 16:58
paulirish pushed a commit that referenced this pull request Mar 23, 2021
@adamraine @paulirish
tests(smoke): ignore lantern script attribution in ToT (#12256)
996c266
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paulirish paulirish Awaiting requested review from paulirish

1 more reviewer

@brendankenny brendankenny brendankenny approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@paulirish paulirish

Labels

cla: yes waiting4reviewer

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@adamraine @brendankenny @paulirish @devtools-bot